Skip to content

Publish 1.11 pre-releases #208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jzaefferer opened this issue May 6, 2014 · 12 comments
Closed

Publish 1.11 pre-releases #208

jzaefferer opened this issue May 6, 2014 · 12 comments

Comments

@jzaefferer
Copy link
Member

At the last UI meeting we discussed publishing the 1.11.0-beta.1 pre-release on jqueryui.com/download, both to increase the odds of users testing the beta (by making it easier to create a custom build as for stable releases) and to test DB before the final release.

Rafael tried this after the meeting and deployed on stage. There were two problems I found: The 1.11 release was listed as "Legacy" (should beta "Pre-release") and Selectmenu wasn't listed as a component.

@scottgonzalez
Copy link
Member

The pre-release quick download probably shouldn't be the first link under quick downloads either.

jzaefferer added a commit to jzaefferer/download.jqueryui.com that referenced this issue May 6, 2014
rxaviers added a commit that referenced this issue May 6, 2014
JQuery UI began to publish pre-releases, eg. 1.11.0-beta.1, which can't be
described as stable nor legacy. So, it turned out that one more option was
needed: "pre-release".

Ref: #208
@rxaviers
Copy link
Member

rxaviers commented May 6, 2014

The 1.11 release was listed as "Legacy" (should beta "Pre-release")

Fixed by dc2d86f. The implementation creates a new attribute pre-release, which when set to true outputs "Pre-release" in the description. There are other alternatives to the way I have implemented it, eg. we could create an attribute description where we define the "Pre-release", "Legacy", or "Stable" strings. Please, just let me know in case you want to change it.

and Selectmenu wasn't listed as a component.

jQuery UI 1.0.0-beta.1 misses ui.selectmenu.jquery.json metafile.

The pre-release quick download probably shouldn't be the first link under quick downloads either.

Which order should it appear? It could be changed by changing the order it appears in config.json.

@jzaefferer
Copy link
Member Author

@rxaviers thanks for the update. I prefer the approach using a separate attribute, as proposed in #211.

@jzaefferer
Copy link
Member Author

A PR to add the selectmenu manifest: jquery/jquery-ui#1240

@scottgonzalez
Copy link
Member

Which order should it appear? It could be changed by changing the order it appears in config.json.

Let's do stable, pre-release, legacy.

@rxaviers
Copy link
Member

rxaviers commented May 7, 2014

I prefer the approach using a separate attribute, as proposed in #211.

Ok! But, you mean #210, right? :)

In the lack of internet, I had implemented it offline, and I haven't seen your solution ☺️ I've updated my PR to drop my implementation.

Let's do stable, pre-release, legacy.

Updated on #211

@jzaefferer
Copy link
Member Author

Yes, #210, correct. I've updated that PR to include the reordering from your's. If that looks good, I'll rebase/squash and land that. We can actually deploy it when releasing rc.1, since we don't have the selectmenu manifest in beta.1.

@rxaviers
Copy link
Member

@jzaefferer it looked good to me

@jzaefferer
Copy link
Member Author

@rxaviers okay, I've squashed and pushed to master. To test on stage I need to npm version patch here, then update package.json in jqueryui.com without tagging, right?

@rxaviers
Copy link
Member

In here, npm version patch, push, and npm publish. On jqueryui.com, correct, update package.json and push.

@jzaefferer
Copy link
Member Author

Alright, that's done, looking good: http://stage.jqueryui.com/download/

@rxaviers
Copy link
Member

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants