Make DB not dependent on jquery-ui generating a build #146

rxaviers · 2013-05-22T20:40:02Z

Summary: (the goal)

To build jquery-ui (concatenate, minify, change banner, change @VERSION variable, etc) by our own. This is: drop requirement to prepare the jquery-ui files by running its build, and release tasks. (Obs: DB still requires to prepare the jquery-ui files running its manifest task.)
Avoid to break anything, including third-parties (jqueryui.com and jquery-ui and its tasks that depends on DB).
Facilitate the cutoff duplicate parts work with jquery-ui, ie. bring release process from jquery-ui into DB.

Tests: (making sure this PR is good)

jshint and npm test, of course. Actually, they pass in each commit separately.
Make sure we keep building good solid packages. Follow a diff view between the package downloaded from live site vs. a package downloaded with the code of this PR. Note you will find differences: (a) ignore the images, (b) this PR actually fixes things (see below).
On jquery-ui, grunt generate_themes and grunt release_themes passes.
On jqueryui.com, grunt build-download build-packages needs a slight change PR Grunt: Change db path from release to jquery-ui jqueryui.com#55.

Changes: (the details)

Make DB not dependent on jquery-ui release task. Along with that, I've renamed the Release lib for jQueryUI (and release path for jquery-ui), so we don't make confusion with the release procedure.
Make DB not dependent on jquery-ui build task. Note, it's using the default options of uglifyjs-2 and sqwish (for css).
Cache built files. Since we are building it, it's being cached for performance. Actually, I've split the build (Builder) of the packaging (Packer) part. And actually2, since I've split them, it was more clear that we could cache more things. So, downloads are 12.5% faster.
Organization. I made files manipulation more uniform across jQueryUI, Builder, Packer libs. They all use Files, which extends an Array and adds methods to make its usage more clean in Packer (see into(), and rename()).

Related PRs

…ion (default: ".custom")

- also rename release -> jquery-ui;

- rename Builder#writeTo to Builder#zipTo;

…tiate themeGallery

…iles not included)

…ass, show, switchClass, toggle, and toggleClass demos

…eClass, show, switchClass, toggle, and toggleClass demos are included when effect core is

… on selected components

- Add ';' separator between copyright and licenses, eg. "Copyright 2013 jQuery Foundation and other contributors; Licensed MIT"; - Add a line break between banner and code; - Add `jquery.ui.theme.css` in the includes list of bundle css'es (it was missing);

- Unbinds ThemeRoller from JqueryUi.find(), ie. from the prepared files of the config file. Therefore, it can be used independently;

… cleaner add( src, dst ) -> add( src, dst, [ data ] )

…nd its manifest files

…y methods and inlining it

… chaining more straightforward - Along with related changes, builder helper add method changed as below: add( src, dst, [ data ] ) -> add( file ) or add( src, data )

rxaviers · 2013-05-22T20:48:04Z

@scottgonzalez @jzaefferer some commits for your appreciation :)

rxaviers · 2013-05-22T21:04:36Z

lib/files.js

+	}
+});
+
+module.exports = Files;


I tried not to use proto (which is a non-standard). But, in my alternatives, length doesn't work properly, and therefore .map, .forEach, .concat, ... don't work properly too.

We need to check whether we are ok using this code, knowing we only use it in a controlled environment. After all, the above code works like a charm. :)

I've talked with @rwldrn and I learned ES6 will have a smarter object initialization. On ES5, it is not possible to subclass a built-in. But, ES6 will eventually make it possible.

I wonder if we can leave a TODO note above stating that as soon as our env supports ES6, we rewrite it in the proper way OR we use an alternative code that isn't too much complex.

- JqueryUiFiles_<version> inherit from JqueryUiFiles;

…variable instead (fix).

jzaefferer · 2013-06-14T21:29:52Z

Gruntfile.js

 	], function( err ) {
-		// Make grunt to quit properly. Here, a proper error message should have been printed already.
-		// 1: true on success, false on error
 		done( !err /* 1 */ );


remove comment

rxaviers · 2013-06-17T17:44:43Z

Closed by 84b5074

rxaviers added 24 commits May 17, 2013 08:51

Drop requirement of a jQuery UI release, instead use a jQuery UI build

fcf31ee

bundleSuffix option, allow bundle filename suffix to be passed as opt…

72f8b16

…ion (default: ".custom")

Rename Release -> JqueryUi

f7e1211

- also rename release -> jquery-ui;

Remove unecessary globedJqueryUiPath

7dfafe0

skipDocs option, make docs inclusion optional (default: docs included)

fa3607f

Move zip helper algorithm into util.createZip

570ff57

- rename Builder#writeTo to Builder#zipTo;

themeGallery( jqueryUi ), allow passing a jQuery UI version to instan…

a489d49

…tiate themeGallery

skipTheme option, allow a theme to be skipped (default: theme included)

cef2b70

Add a special keyword ":all:" that allows to select all the components

6db7e23

Minor fixes and some delayed libs loading

ff750e6

addTests option allows Builder to include test files (default: test f…

9961e1c

…iles not included)

If effect core is selected, include addClass, animate, hide, removeCl…

28fcdaf

…ass, show, switchClass, toggle, and toggleClass demos

Extending builder testcase to check if addClass, animate, hide, remov…

f699ab4

…eClass, show, switchClass, toggle, and toggleClass demos are included when effect core is

Coding standard fix

6a8180a

Include demos/index.html the right way, ie. generated on demand based…

89d4035

… on selected components

Replace @Version with pkg.version

7c4d459

Selectively pick /* files

bb97268

Keep jqueryUi instance instead of version string

361a2df

- Unbinds ThemeRoller from JqueryUi.find(), ie. from the prepared files of the config file. Therefore, it can be used independently;

Add optional data parameter to add() helper function. It makes code…

388bd8e

… cleaner add( src, dst ) -> add( src, dst, [ data ] )

Make encoding name uniform across code: utf-8 -> utf8

af847c1

Drop requirement of a jQuery UI build, instead use jQuery UI source a…

c19fdbc

…nd its manifest files

Simplify dependencies helper function by using ecma-5 Object and Arra…

7b25ccb

…y methods and inlining it

Make each file of JqueryUiFiles a {path, data} key-pair value. Allows…

92a6928

… chaining more straightforward - Along with related changes, builder helper add method changed as below: add( src, dst, [ data ] ) -> add( file ) or add( src, data )

rxaviers mentioned this pull request May 22, 2013

Grunt: Change db path from release to jquery-ui jquery/jqueryui.com#55

Closed

rxaviers reviewed May 22, 2013
View reviewed changes

rxaviers mentioned this pull request May 27, 2013

Export DownloadBuilder, so jQueryUI Release Script can use it #139

Merged

rxaviers added 2 commits May 27, 2013 11:34

Split Builder -> {Packer, Builder}

2be80d1

Simplify by splitting files.into() -> {files.rename(), file.into()}

b6f37ca

rxaviers added 9 commits May 27, 2013 11:35

Move Files() into a separate file

5e435fb

Code format preference (minor)

12c7690

Move JqueryUiFiles into a separate file

f00bd09

Handle each version specifics in a separate file

b596979

- JqueryUiFiles_<version> inherit from JqueryUiFiles;

Update banner on minification

26873e9

Separate Cache manager from ThemeRoller Image

f8e0aa7

Cache Builder

480e226

Workaround to keep jquery ui's generate_theme working

f651884

Read @VERSION-replaced data. Reading the file directly gets @Version …

b3a733c

…variable instead (fix).

jzaefferer reviewed Jun 14, 2013
View reviewed changes

rxaviers added 2 commits June 17, 2013 14:13

Code pattern. Move error code into conditional scope

b047072

Comment fixes

badf450

rxaviers closed this Jun 17, 2013

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Make DB not dependent on jquery-ui generating a build #146

Make DB not dependent on jquery-ui generating a build #146

Uh oh!

rxaviers commented May 22, 2013

Uh oh!

rxaviers commented May 22, 2013

Uh oh!

rxaviers May 22, 2013

Uh oh!

jzaefferer Jun 14, 2013

Uh oh!

rxaviers commented Jun 17, 2013

Uh oh!

Uh oh!

Make DB not dependent on jquery-ui generating a build #146

Make DB not dependent on jquery-ui generating a build #146

Uh oh!

Conversation

rxaviers commented May 22, 2013

Uh oh!

rxaviers commented May 22, 2013

Uh oh!

rxaviers May 22, 2013

Choose a reason for hiding this comment

Uh oh!

jzaefferer Jun 14, 2013

Choose a reason for hiding this comment

Uh oh!

rxaviers commented Jun 17, 2013

Uh oh!

Uh oh!