Skip to content

Support multiple versions#187

Merged
rxaviers merged 1 commit intomasterfrom
multiple-versions
Dec 26, 2013
Merged

Support multiple versions#187
rxaviers merged 1 commit intomasterfrom
multiple-versions

Conversation

@rxaviers
Copy link
Member

Fix #181

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now, config accepts an array of unlimited jquery-ui entries. Now, stable becomes an attribute.

@rxaviers
Copy link
Member Author

For illustrative purposes, this is how it looks like if we had the following three versions in the config: 1.11.0, 1.10.3, 1.9.2:

config.json:

{
    "jqueryUi": [
        {
            "version": "1.11.0",
            "dependsOn": "jQuery1.6+",
            "stable": true
        },
        {
            "version": "1.10.3",
            "dependsOn": "jQuery1.6+",
        },
        {
            "version": "1.9.2",
            "dependsOn": "jQuery1.6+"
        }
    ],
    "jquery": "1.9.1"
}

npm test tests all versions defined in the config:

$ npm test

> download.jqueryui.com@1.11.0pre test /home/xavier/jquery/download.jqueryui.com
> nodeunit test


banner
✔ test: case 1

jquery-ui
✔ 1.11.0pre - test: common files present
✔ 1.11.0pre - test: component files present
✔ 1.11.0pre - test: demo files present
✔ 1.11.0pre - test: doc files present
✔ 1.11.0pre - test: base theme files present
✔ 1.10.3 - test: common files present
✔ 1.10.3 - test: component files present
✔ 1.10.3 - test: demo files present
✔ 1.10.3 - test: doc files present
✔ 1.10.3 - test: base theme files present
✔ 1.9.2 - test: common files present
✔ 1.9.2 - test: component files present
✔ 1.9.2 - test: demo files present
✔ 1.9.2 - test: doc files present
✔ 1.9.2 - test: base theme files present

packer
✔ 1.11.0pre - test: select all components - with a theme
✔ 1.11.0pre - test: select all components - with a named theme
✔ 1.11.0pre - test: select all components - no theme
✔ 1.11.0pre - test: select all widgets
✔ 1.11.0pre - test: select all effects
✔ 1.11.0pre - test: select some widgets (1) - with a theme
✔ 1.11.0pre - test: select some widgets (1) - with a named theme
✔ 1.11.0pre - test: select some widgets (1) - no theme
✔ 1.11.0pre - test: select some widgets (2)
✔ 1.11.0pre - test: select no components
✔ 1.11.0pre - test: scope widget CSS
✔ 1.11.0pre - test: unique files

packer.legacy.1.10
✔ 1.10.3 - test: select all components - with a theme
✔ 1.10.3 - test: select all components - with a named theme
✔ 1.10.3 - test: select all components - no theme
✔ 1.10.3 - test: select all widgets
✔ 1.10.3 - test: select all effects
✔ 1.10.3 - test: select some widgets (1) - with a theme
✔ 1.10.3 - test: select some widgets (1) - with a named theme
✔ 1.10.3 - test: select some widgets (1) - no theme
✔ 1.10.3 - test: select some widgets (2)
✔ 1.10.3 - test: select no components
✔ 1.10.3 - test: scope widget CSS
✔ 1.10.3 - test: unique files

packer.legacy.1.9
✔ 1.9.2 - test: select all components - with a theme
✔ 1.9.2 - test: select all components - with a named theme
✔ 1.9.2 - test: select all components - no theme
✔ 1.9.2 - test: select all widgets
✔ 1.9.2 - test: select all effects
✔ 1.9.2 - test: select some widgets (1) - with a theme
✔ 1.9.2 - test: select some widgets (1) - with a named theme
✔ 1.9.2 - test: select some widgets (1) - no theme
✔ 1.9.2 - test: select some widgets (2)
✔ 1.9.2 - test: select no components
✔ 1.9.2 - test: unique files

themeroller
✔ test: folder name - default "custom-theme"
✔ test: folder name - default when theme is null "no-theme"
✔ test: folder name - custom folder name based on theme's name
✔ test: folder name - custom folder name

OK: 9939 assertions (42557ms)

Download page:
screenshot from 2013-12-26 12 27 51

@rxaviers
Copy link
Member Author

@scottgonzalez @jzaefferer do you think the page could be rendered differently now that we'll have multiple versions?

@scottgonzalez
Copy link
Member

I think checkboxes are fine for now. If we start adding more than three versions, we might want to switch to a dropdown.

@tjvantoll
Copy link
Member

@scottgonzalez By checkboxes I assume you meant radio buttons?

I think the radio buttons for versions are fine.

@rxaviers
Copy link
Member Author

Ok

http://www.rafael.xavier.blog.br/+55 (16) 8138-1583, skype: rxaviers
http://rafael.xavier.blog.br

@rxaviers rxaviers merged commit 548e32d into master Dec 26, 2013
@rxaviers rxaviers deleted the multiple-versions branch January 28, 2014 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Support multiple versions

3 participants