bump archiver dep to v0.5.1. replace addFile with append.

[ctalkington]

archiver 0.5.1 is out and has many under the hood improvements. also, to note you shouldn't need to use async (archiver handles internally with queue) but because I can't seem to get tests to run locally (windows 7) due to node-syslog build error. I passed on making that change for time being.

[ctalkington]

just wanted to bump this before it becomes an issue to merge like some of my previous attempts to contribute.

[rxaviers]

Thanks to bring this update @ctalkington. I'm rebasing a to-be-landed-branch on top of your update, and testing it to make sure it works just fine first.

[ctalkington]

@rxaviers sounds good. let me know if anything pops out.

[rxaviers]

@ctalkington functionally, it worked just fine. Although, I have noticed a decrease on performance. My dry tests showed it's 30% slower (from 572ms mean to 734ms mean).

Do you have any performance comparison between 0.5 vs. 0.4?

[ctalkington]

interesting. i know a contributor had setup a speed bench script at one point but it was more related to the speed going stream to stream not time. either way never seemed to vary for me (could be limited by compression or such).

the change could come from a few places, since you were using 0.4.1 locked and there are 9 bugfix releases and 1 major release since. where are seeing said times? i would be intrigued to walk through the versions and see if it was a bugfix that caused it or the breaking apart to use tar-stream in 0.5

[ctalkington]

i personally think the async could also be adding some un-needed time to wrap each when archiver can handle it internally. ill try to run the tests tonight on a linux vps that should compile syslog.

[ctalkington]

@rxaviers testing this package isn't all that heavily documented and a chore. linux vps is having issues.. any guidance greatly appreciated.

removed for cleanness

[rxaviers]

Hm ok. It would be good if we had a simple perf benchmark...

If you want to give a try using download builder: please, rebase your branch on top of current master. We had an issue on grunt prepare that has been fixed (if problem persists, just let me know please).

You will notice the times I've talked about by running the server, browsing, clicking download, then observing build_time on log/downloads.log.

[ctalkington]

@rxaviers still hitting some issues.

$ grunt prepare
...
Installing api.jqueryui.com npm modules
>> Error installing npm modules: undefined
Warning: Task "prepare-jquery-ui" failed. Use --force to continue.

$ npm test
...
/vagrant/lib/jquery-ui.js:55
                                throw new Error( "Missing ./" + require( "path" ).relative
( __dirname, pat
                                      ^
Error: Missing ./../jquery-ui/1.10.4 folder. Run `grunt prepare` first, or fix your config
 file.

[ctalkington]

and using force

Running "prepare-jquery-ui" task
Fetch updates for jquery-ui repo
>> Fetched repo
Fetch updates for api.jqueryui.com repo
>> Fetched repo
Checking out jquery-ui branch/tag: 1.10.4
>> Done with checkout
Did not find a "1-10" branch, using "master"
Checking out api.jqueryui.com branch/tag: origin/master
>> Done with checkout
Installing jquery-ui npm modules
>> Installed npm modules
Installing api.jqueryui.com npm modules
>> Installed npm modules
Building manifest for jQuery UI
>> Done building manifest
Building API documentation for jQuery UI
Copied config-sample.json to config.json
>> Error building documentation: undefined

[rxaviers]

😕 this is what I get https://gist.github.com/rxaviers/06a6cc9c24d2136c5c9d

What's your output of git log --oneline? Mine is:

4abf5af bump archiver dep to v0.5.1. replace addFile with append.
f16f902 Gruntfile: Build API docs with `grunt build`
e1f90b6 jQueryUiFiles1.10: recursive docFiles with no dirs
44a70a5 Config: Replace 1.10.3 with 1.10.4

[ctalkington]

wierd do you happen to have any changes to a config or something. can't seem to get past Building API documentation for jQuery UI; tried node 0.8 and 0.10.

vagrant@precise32:/vagrant$ git log --oneline
e5238c6 bump archiver dep to v0.5.1. replace addFile with append.
f16f902 Gruntfile: Build API docs with `grunt build`
e1f90b6 jQueryUiFiles1.10: recursive docFiles with no dirs
44a70a5 Config: Replace 1.10.3 with 1.10.4
bd47823 jQueryUiFiles1.11: recursive docFiles with no dirs
6b4fa2f Docs: Removed IRC channel links in CONTRIBUTING.md

[rxaviers]

Do you use IRC? Could you ping me at Freenode #jquery-dev?

[ctalkington]

sorry this fell off my radar. and ive since released archiver v0.6. will do new PR some point in the future.

[rxaviers]

Thank you! Looking forward the v0.6 PR.