jQuery UI Themes Packer: Remove basedir from manifest paths, with optional slash#203
Closed
jzaefferer wants to merge 1 commit intojquery:masterfrom
Closed
jQuery UI Themes Packer: Remove basedir from manifest paths, with optional slash#203jzaefferer wants to merge 1 commit intojquery:masterfrom
jzaefferer wants to merge 1 commit intojquery:masterfrom
Conversation
lib/themes-packer.js
Outdated
Member
There was a problem hiding this comment.
Shouldn't basedir be escape if it's passed to new RegExp()?
…ional slash This works when basedir is set to "" (empty string), where removing the first segment actually destroys all paths. Tested with jQuery UI's release script. This also works with the default, tested using the build-packages grunt task.
Member
Author
|
Updated to slide of the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This works when basedir is set to "" (empty string), where removing the
first segment actually destroys all paths. Tested with jQuery UI's release
script.
This also works with the default, tested using the build-packages grunt task.