-
Notifications
You must be signed in to change notification settings - Fork 74
New ThemeRoller demos #251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Figured it out. 80b5b18 |
@jzaefferer ready for review |
|
I assume this needs to also be fixed in https://github.com/jquery/download.jqueryui.com/blob/master/template/zip/index-1-12.html#L115, right? What about this same fix for index.html of previous versions (<1.12)? |
I'm fine with not changing older versions, since they don't use the |
Became its own ticket #252. |
- Remove the "(not currently used in UI widgets)" text; - Update application: Shadow opacity and Corners (also under Dropshadow) should have title "Not in use anymore in 1.12";
Please, can you verify 27f5f5c |
Diff looks good. Didn't you want to reuse the zip template for the TR template, or the other way around? Can refactor that later, as long as its tracked. |
Right now although it's the same content, there are duplicate templates. Ideally, we should use the same template for zip's index.html and themeroller demos #253. |
body{ | ||
font-family: "Trebuchet MS", sans-serif; | ||
margin: 50px; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to be fixed. s/body/#themeroller
Reviewing #248 on the stage server, @jzaefferer asked if ThemeRoller demos page could be updated similarly to https://github.com/jquery/download.jqueryui.com/pull/248/files#diff-14 changes. I proposed using the same content for easier maintenance and consistency. This PR implements such.
This change happens to also fix #242.
TODO: