Skip to content

New ThemeRoller demos #251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

New ThemeRoller demos #251

wants to merge 4 commits into from

Conversation

rxaviers
Copy link
Member

Reviewing #248 on the stage server, @jzaefferer asked if ThemeRoller demos page could be updated similarly to https://github.com/jquery/download.jqueryui.com/pull/248/files#diff-14 changes. I proposed using the same content for easier maintenance and consistency. This PR implements such.

This change happens to also fix #242.

TODO:

  • Drop temporary changes commit.

@rxaviers
Copy link
Member Author

Some screenshots...

screenshot from 2015-01-27 19 01 47


screenshot from 2015-01-27 19 13 09


screenshot from 2015-01-27 19 13 17


screenshot from 2015-01-27 19 13 23

@rxaviers
Copy link
Member Author

Overlay is buggy. I don't know what's going on here.

screenshot from 2015-01-27 19 12 34

@rxaviers
Copy link
Member Author

Overlay is buggy. I don't know what's going on here.

Figured it out. 80b5b18

screenshot from 2015-01-27 22 22 40

@rxaviers
Copy link
Member Author

@jzaefferer ready for review

@jzaefferer
Copy link
Member

  • remove the "(not currently used in UI widgets)" text
  • Update application: Shadow opacity and Corners (also under Dropshadow) should have title "Not in use anymore in 1.12"
  • Use smart position:fixed for application to stay in view

@rxaviers
Copy link
Member Author

remove the "(not currently used in UI widgets)" text

I assume this needs to also be fixed in https://github.com/jquery/download.jqueryui.com/blob/master/template/zip/index-1-12.html#L115, right? What about this same fix for index.html of previous versions (<1.12)?

@jzaefferer
Copy link
Member

I'm fine with not changing older versions, since they don't use the ui-widget-shadow class. We can remove it there as well, since it doesn't really help, and the overlay class is actually used by dialog.

@rxaviers
Copy link
Member Author

Use smart position:fixed for application to stay in view

Became its own ticket #252.

- Remove the "(not currently used in UI widgets)" text;
- Update application: Shadow opacity and Corners (also under Dropshadow)
  should have title "Not in use anymore in 1.12";
@rxaviers
Copy link
Member Author

remove the "(not currently used in UI widgets)" text
Update application: Shadow opacity and Corners (also under Dropshadow) should have title "Not in use anymore in 1.12"

Please, can you verify 27f5f5c

@jzaefferer
Copy link
Member

Diff looks good.

Didn't you want to reuse the zip template for the TR template, or the other way around? Can refactor that later, as long as its tracked.

@rxaviers
Copy link
Member Author

Didn't you want to reuse the zip template for the TR template, or the other way around? Can refactor that later, as long as its tracked.

Right now although it's the same content, there are duplicate templates. Ideally, we should use the same template for zip's index.html and themeroller demos #253.

body{
font-family: "Trebuchet MS", sans-serif;
margin: 50px;
}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be fixed. s/body/#themeroller

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants