Skip to content

All: Adapt to latest structural changes in 1.12#274

Merged
jzaefferer merged 4 commits intojquery:masterfrom
jzaefferer:12-fixup
Oct 23, 2015
Merged

All: Adapt to latest structural changes in 1.12#274
jzaefferer merged 4 commits intojquery:masterfrom
jzaefferer:12-fixup

Conversation

@jzaefferer
Copy link
Member

This is already fixing a bunch of issues with 1.12, but I'm not done. The UI seems to be okay (needs more testing though), but downloads fail while trying to strip banners from built CSS files. Haven't yet figured out what's wrong there.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an incomplete fix to deal with the new folder structure. Widget-to-widget dependencies are still broken.

@rxaviers
Copy link
Member

Seems good. Please, just let me know if you need clarification of the existing code.

@jzaefferer
Copy link
Member Author

Yes, I could use some help. This fails because data is undefined: https://github.com/jquery/download.jqueryui.com/blob/master/lib/package-1-12.js#L190

I still have no idea why. path is "dist/themes/base/core.css", I don't know where the "dist" part comes from.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a questionable amount of processing, but seems solid enough.

@rxaviers
Copy link
Member

Yes, I could use some help. This fails because data is undefined: https://github.com/jquery/download.jqueryui.com/blob/master/lib/package-1-12.js#L190

I still have no idea why. path is "dist/themes/base/core.css", I don't know where the "dist" part comes from.

As you may have noticed everything is so better modularized now. So, I think a good first step is making sure that https://github.com/rxaviers/builder-jquery-css still works after UI file changes.

@jzaefferer jzaefferer changed the title [WIP] All: Adapt to latest structural changes in 1.12 All: Adapt to latest structural changes in 1.12 Oct 23, 2015
@jzaefferer jzaefferer force-pushed the 12-fixup branch 2 times, most recently from 14cfc43 to 167eeae Compare October 23, 2015 16:49
@jzaefferer jzaefferer force-pushed the 12-fixup branch 8 times, most recently from b34ab5c to 1a39ac5 Compare October 23, 2015 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants