Skip to content

Package 1 12 themes#286

Merged
jzaefferer merged 1 commit intomasterfrom
package-1-12-themes
Dec 2, 2015
Merged

Package 1 12 themes#286
jzaefferer merged 1 commit intomasterfrom
package-1-12-themes

Conversation

@jzaefferer
Copy link
Member

@jzaefferer jzaefferer commented Nov 26, 2015

Fixes #282

Goes together with https://github.com/jquery/jquery-ui/pull/1642/files

  • Missing license info in header comments.
  • Includes header comment is missing the individual effects.
  • AMD wrappers are not stripped from each module.
  • Minified CSS files don't have header comments for includes or edit URL.

This was referenced Nov 26, 2015
Merged
Closed
@scottgonzalez
Copy link
Member

scottgonzalez commented Dec 2, 2015

Missing license info in header comments.

@scottgonzalez
Copy link
Member

scottgonzalez commented Dec 2, 2015

Includes header comment is missing the individual effects.

@scottgonzalez
Copy link
Member

scottgonzalez commented Dec 2, 2015

AMD wrappers are not stripped from each module.

@scottgonzalez
Copy link
Member

scottgonzalez commented Dec 2, 2015

Minified CSS files don't have header comments for includes or edit URL.

@rxaviers
Copy link
Member

rxaviers commented Dec 2, 2015

Worth checking if the same @scottgonzalez's comments also apply to the regular 1.12 package. If not, that package could be used as baseline for fixing this one.

@scottgonzalez
Copy link
Member

scottgonzalez commented Dec 2, 2015

Much better!

@rxaviers @jzaefferer
Package: Add missing files to 1.12 package, add separate for themes
039957a 
Fixes the missing license in the banner, now looks at pkg.license first,
then falls back to the deprecated pkg.licenses.

Fixes #282
Closes #286
@jzaefferer jzaefferer merged commit 039957a into master Dec 2, 2015
@jzaefferer
Copy link
Member Author

jzaefferer commented Dec 2, 2015

Turned out 2 out of the 4 issues were invalid (looking at old files in dist/), fixed the other two. Merged and published as 2.1.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jzaefferer @scottgonzalez @rxaviers @jquerybot