Skip to content

Config: Allow different jQuery UI version to be specified for ThemeRoller page #288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rxaviers wants to merge 1 commit into from
Closed

Config: Allow different jQuery UI version to be specified for ThemeRoller page #288

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,8 @@
{
"themeroller": {
"jquery": "1.7",
"jqueryUi": "1.12.0-beta.1"
},
"jqueryUi": [
{
"version": "1.12.0-beta.1",
Expand Down
4 changes: 3 additions & 1 deletion frontend.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,9 @@ Frontend.defaults = {
host: "",
resources: {
jqueryVersion: config.jquery,
jqueryuiVersion: JqueryUi.getStable().pkg.version
jqueryuiVersion: JqueryUi.getStable().pkg.version,
jqueryVersionForThemeRoller: config.themeroller.jquery,
jqueryuiVersionForThemeroller: config.themeroller.jqueryUi
}
};

Expand Down
4 changes: 2 additions & 2 deletions template/themeroller/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<link rel="stylesheet" href="https://code.jquery.com/ui/{{resources.jqueryuiVersion}}/themes/smoothness/jquery-ui.css">
<link rel="stylesheet" href="https://code.jquery.com/ui/{{resources.jqueryuiVersionForThemeroller}}/themes/smoothness/jquery-ui.css">
{{#if production}}
<link rel="stylesheet" href="/resources/external/farbtastic.css">
<link rel="stylesheet" href="/resources/themeroller.css">
Expand All @@ -16,7 +16,7 @@
</div>
</div>

<script src="https://code.jquery.com/ui/{{resources.jqueryuiVersion}}/jquery-ui.min.js"></script>
<script src="https://code.jquery.com/ui/{{resources.jqueryuiVersionForThemeroller}}/jquery-ui.min.js"></script>
{{#if production}}
<script src="/resources/themeroller.all.min.js"></script>
{{else}}
Expand Down
2 changes: 1 addition & 1 deletion template/themeroller/wrap.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<html lang="us">
<head>
<title>jQuery UI Themeroller</title>
<script src="https://code.jquery.com/jquery-{{resources.jqueryVersion}}.js"></script>
<script src="https://code.jquery.com/jquery-{{resources.jqueryVersionForThemeRoller}}.js"></script>
<script>
// add js to html element for css selectors
// usually handled by WordPress theme
Expand Down