Skip to content

Grunt: Extend build-packages task to support 1.12#290

Merged
jzaefferer merged 1 commit intomasterfrom
build-packages-1-12
Jan 26, 2016
Merged

Grunt: Extend build-packages task to support 1.12#290
jzaefferer merged 1 commit intomasterfrom
build-packages-1-12

Conversation

@jzaefferer
Copy link
Member

To test locally, run grunt prepare once, then:

mkdir tmpresources
grunt build-packages:tmpresources

Unzip a few files and compare differences between 1.11 and 1.12. What I noticed so far and figured acceptable:

  • 1.12 package adds AUTHORS.txt, LICENSE.txt and package.json compared to 1.11 package. We added those on purpose.
  • 1.12 themes package contains sames files as non-themes package, along with the themes folder. Doesn't hurt.

If it fails to build 1.9.2 packages, just remove that version from config.json temporarily.

@scottgonzalez
Copy link
Member

Looks good. It'd be nice if the themes zip didn't contain the JS, but I'm not too concerned about it.

@jzaefferer
Copy link
Member Author

Excluding the JS files is easy enough. It would still include 4 css files in the root folder (jquery-ui.css, jquery-ui.min.css, jquery-ui.theme.css, jquery-ui.theme.min.css).

@scottgonzalez
Copy link
Member

And that would be the new default theme. I think that's fine.

@jzaefferer
Copy link
Member Author

Updated. Could you test once more? Then I'll merge and publish this and update jqueryui.com accordingly.

@scottgonzalez
Copy link
Member

Looks good.

@jzaefferer jzaefferer merged commit 34648a2 into master Jan 26, 2016
@jzaefferer jzaefferer deleted the build-packages-1-12 branch January 26, 2016 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants