Fix globbing patterns used for jQuery UI 1.12 files list generation #580
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`fast-glob` to which we switched from `glob` doesn't seem to exclude dotfiles in a path segment matched by an exclusion; explicitly exclude dotfiles in the pattern to account for that. Without this fix, directories like `.git` would end up in the zip file generated for CDN purposes.
fnagel
approved these changes
Aug 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fast-globto which we switched fromglobdoesn't seem to exclude dotfilesin a path segment matched by an exclusion; explicitly exclude dotfiles in the
pattern to account for that. Without this fix, directories like
.gitwouldend up in the zip file generated for CDN purposes.