Skip to content

Package: Don't strip "use strict" pragmas from 1.13, improve formatting #583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 26, 2021

Conversation

mgol
Copy link
Member

@mgol mgol commented Aug 25, 2021

Changes:

  • Fix formatting of one of the outer "use strict" pragmas
  • String "use strict" pragmas from individual unwrapped modules as those
    pragmas only make sense at the beginning of a function wrapper we're removing
  • Instruct RequireJS to not remove "use strict" pragmas from compiled code.

This will make jQuery UI 1.13 use strict mode both for modules and for the built
files.

Changes:
* Fix formatting of one of the outer `"use strict"` pragmas
* String `"use strict"` pragmas from individual unwrapped modules as those
pragmas only make sense at the beginning of a function wrapper we're removing
* Instruct RequireJS to not remove `"use strict"` pragmas from compiled code.

This will make jQuery UI 1.13 use strict mode both for modules and for the built
files.
Copy link
Member

@fnagel fnagel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 by reading

@mgol mgol merged commit 8973ee2 into jquery:main Aug 26, 2021
@mgol mgol deleted the 1-13-fixes branch August 26, 2021 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants