Skip to content

Tests: Migrate from nodeunit to QUnit, update dependencies #618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 19, 2024

Conversation

mgol
Copy link
Member

@mgol mgol commented Jul 19, 2024

No description provided.

@mgol mgol requested review from fnagel, Krinkle and timmywil July 19, 2024 15:53
@mgol
Copy link
Member Author

mgol commented Jul 19, 2024

Since there are indentation changes, it might be a bit easier to review it with whitespace changes off.

Copy link
Member

@Krinkle Krinkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit, LGTM otherwise.

@mgol mgol requested a review from Krinkle July 19, 2024 16:28
Copy link
Member

@timmywil timmywil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@mgol mgol changed the title Tests: Migrate from nodeunit to QUnit Tests: Migrate from nodeunit to QUnit, uodate dependencies Jul 19, 2024
@mgol mgol merged commit 633a9ab into jquery:main Jul 19, 2024
3 checks passed
@mgol mgol deleted the qunit branch July 19, 2024 21:52
@mgol mgol changed the title Tests: Migrate from nodeunit to QUnit, uodate dependencies Tests: Migrate from nodeunit to QUnit, update dependencies Jul 19, 2024
mgol added a commit that referenced this pull request Jul 19, 2024
@mgol
Copy link
Member Author

mgol commented Jul 19, 2024

Landed in 5f01a26.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants