Build: Remove unused tap-diff, test on Node 22, update actions #619
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`tap-diff` was temporarily added before the decision to avoid modifying QUnit output and I forgot to remove it. Also, add testing on Node 22. It was broken in `22.5.0` due to a bug fixed upstream in `22.5.1`. In addition, update GitHub Actions.
|
OK, it's still picking up Node 22.5.0 despite 22.5.1 being released 6 hours ago: https://github.com/actions/node-versions/releases/tag/22.5.1-10010673511. I'll re-try this later. |
fnagel
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tap-diffwas temporarily added before the decision to avoid modifying QUnitoutput and I forgot to remove it.
Also, add testing on Node 22. It was broken in
22.5.0due to a bug fixedupstream in
22.5.1.In addition, update GitHub Actions.