themeroller-image: Migrate to ImageMagick 7 with cross-spawn#632
Merged
mgol merged 3 commits intojquery:mainfrom Mar 10, 2025
Merged
themeroller-image: Migrate to ImageMagick 7 with cross-spawn#632mgol merged 3 commits intojquery:mainfrom
cross-spawn#632mgol merged 3 commits intojquery:mainfrom
Conversation
Changes: * Migrate from ImageMagick 6 used via the `gm` npm package to ImageMagick 7 used via `cross-spawn` * Upgrade the Dockerfile from `node:18-alpine` to `node:22-alpine`
We'll be able to drop this when Ubuntu Plucky is released & available in GitHub Actions.
Member
Author
|
I did a local comparison of before & after and there are small difference between images but not really noticeable to the naked eye - mostly up to 1 step in one of the colors on the RGB scale; perhaps some differences in rounding between ImageMagick 6 & 7. I think that's an acceptable divergence. |
Member
Author
|
I deployed this version to production and it succeeded: https://cloud.digitalocean.com/apps/371ef31e-4951-418a-95b8-2d8f7abc5b7d/deployments/b4219502-135f-4d4f-b208-0d790bb21869?i=6ded9d |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
gmnpm package to ImageMagick 7 used viacross-spawnnode:18-alpinetonode:22-alpineI tested it locally and it seems to work fine. I intend to do another round of testing & comparing the output of before & after before merging.
The current state of the
mainbranch cannot get deployed as the Alpine Docker image installs ImageMagick 7. It took me a while to debug this because of missing logs which I'm trying to address in #631.