Inline a few dependencies, update all dependencies#652
Merged
mgol merged 8 commits intojquery:mainfrom Mar 13, 2026
Merged
Conversation
bdde50b to
a5082c4
Compare
fnagel
approved these changes
Mar 13, 2026
Member
fnagel
left a comment
There was a problem hiding this comment.
+1 by reading (checked each commit)
1. Rename `bower_components` to `external` since we now maintain it patched. 2. Remove non-needed files. 3. Enumerate the needed JS files directly instead of globbing. Ref jquerygh-652
a5082c4 to
f4b7ead
Compare
mgol
added a commit
that referenced
this pull request
Mar 13, 2026
mgol
added a commit
that referenced
this pull request
Mar 13, 2026
mgol
added a commit
that referenced
this pull request
Mar 13, 2026
mgol
added a commit
that referenced
this pull request
Mar 13, 2026
1. Rename `bower_components` to `external` since we now maintain it patched. 2. Remove non-needed files. 3. Enumerate the needed JS files directly instead of globbing. Ref gh-652
mgol
added a commit
that referenced
this pull request
Mar 13, 2026
mgol
added a commit
that referenced
this pull request
Mar 13, 2026
mgol
added a commit
that referenced
this pull request
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inline four jQuery-owned dependencies:
builder-amdbuilder-jquery-cssbuilder-amd-cssrequirejs-memfilesto make it easier to update deep vulnerable dependencies - and then update them. Those dependencies are not used in any other maintained jQuery project.
Tests were migrated from Mocha to QUnit.
builder-amd-cssdepends onrequire-cssvia Bower. That package is available on npm, butbuilder-amd-csscontained custom patches (patch 1, patch 2), so insteadrequire-cssis inlined with these patches intolib/external/require-css. The original source is committed as well for easier audit and jQuery modifications are marked clearly with code comments.Tests pass, plus I tested the Download Builder & the Themeroller locally with these changes.