Skip to content

Update package.json repo URL #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 20, 2016
Merged

Update package.json repo URL #1

merged 1 commit into from
Jun 20, 2016

Conversation

ntwb
Copy link
Contributor

@ntwb ntwb commented Jun 16, 2016

The repo URL needs to be prefixed with the GitHub username, i.e. jquery/eslint-config-jquery

This can also be tested by running npm repo from a terminal prompt inside this repo folder, it should open the default browser to https://github.com/jquery/eslint-config-jquery/

See https://docs.npmjs.com/all#repository

@dmethvin
Copy link
Member

Sounds right to me. @markelog do you want to do this as part of the 1.0.0 update?

@markelog
Copy link
Member

Totally

@ntwb
Copy link
Contributor Author

ntwb commented Jun 17, 2016

ps. I'm all signed off on the jQuery CLA (https://contribute.jquery.org/CLA/) if that's a requirment here

@mgol
Copy link
Member

mgol commented Jun 17, 2016

Would you like to submit a PR?

Michał Gołębiowski

@ntwb
Copy link
Contributor Author

ntwb commented Jun 18, 2016

@markelog
Copy link
Member

@scottgonzalez could you point on me on the right direction on how to implement jquery bot for this repo?

@markelog
Copy link
Member

Will probably release this with 0.1.4, since there is one more thing i want to implement in eslint before releasing major

@mgol
Copy link
Member

mgol commented Jun 20, 2016

@markelog @dmethvin BTW, we need to agree on a release strategy here. I think that any changes to any of the rules that will cause more code to be rejected should warrant a major upgrade of the preset as they're breaking changes to the projects using them. I realise this may mean we'll reach v23 in no time but I don't think it's a huge problem, Chrome is at 51 and the world hasn't ended.

@mgol
Copy link
Member

mgol commented Jun 20, 2016

cc @jzaefferer as he had some thoughts here as well.

@markelog
Copy link
Member

markelog commented Jun 20, 2016

Way back when i designed release strategy for the JSCS - http://jscs.info/overview#versioning-semver which was recently adopted in ESLint - https://github.com/eslint/eslint#user-content-semantic-versioning-policy

I would follow that. Also i don't think this pull is appropriate place to have this discussion, i would suggest to open a different ticket about this

@markelog markelog merged commit 958e0b7 into jquery:master Jun 20, 2016
@markelog
Copy link
Member

Merged, thank you @ntwb

@ntwb ntwb deleted the update-package branch June 20, 2016 23:47
@mgol
Copy link
Member

mgol commented Jun 21, 2016

@markelog Ah, I see it's thought out so I won't create an issue unless sb else has sth to say about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants