-
Notifications
You must be signed in to change notification settings - Fork 21
Update package.json
repo URL
#1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Sounds right to me. @markelog do you want to do this as part of the 1.0.0 update? |
Totally |
ps. I'm all signed off on the jQuery CLA (https://contribute.jquery.org/CLA/) if that's a requirment here ✅ |
Would you like to submit a PR? Michał Gołębiowski |
This IS a pull request https://github.com/jquery/eslint-config-jquery/pull/1/files |
@scottgonzalez could you point on me on the right direction on how to implement jquery bot for this repo? |
Will probably release this with 0.1.4, since there is one more thing i want to implement in eslint before releasing major |
@markelog @dmethvin BTW, we need to agree on a release strategy here. I think that any changes to any of the rules that will cause more code to be rejected should warrant a major upgrade of the preset as they're breaking changes to the projects using them. I realise this may mean we'll reach v23 in no time but I don't think it's a huge problem, Chrome is at 51 and the world hasn't ended. |
cc @jzaefferer as he had some thoughts here as well. |
Way back when i designed release strategy for the JSCS - http://jscs.info/overview#versioning-semver which was recently adopted in ESLint - https://github.com/eslint/eslint#user-content-semantic-versioning-policy I would follow that. Also i don't think this pull is appropriate place to have this discussion, i would suggest to open a different ticket about this |
Merged, thank you @ntwb |
@markelog Ah, I see it's thought out so I won't create an issue unless sb else has sth to say about it. |
The repo URL needs to be prefixed with the GitHub username, i.e.
jquery/eslint-config-jquery
This can also be tested by running
npm repo
from a terminal prompt inside this repo folder, it should open the default browser to https://github.com/jquery/eslint-config-jquery/See https://docs.npmjs.com/all#repository