Skip to content

Build: use JS for eslint config #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 11, 2023
Merged

Build: use JS for eslint config #20

merged 2 commits into from
Jul 11, 2023

Conversation

timmywil
Copy link
Member

@timmywil timmywil commented Jul 11, 2023

  • this makes it easier to use this config in esm eslint.config.js

To lint the config itself without changing the config, I've moved it to index.js and added a .eslintrc.js for this package that extends index.js and sets node: true.

Helps with jquery/jquery#5297

- this makes it easier to use this config in esm
  eslint.config.js
Copy link
Member

@mgol mgol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it change anything beyond the fact we can lint the file within this repo?

We're still not doing that, BTW. Please expand npm test to lint the whole project.

@timmywil
Copy link
Member Author

Yes, you cannot import JSON in eslint.config.js without a warning. Switching to JS simplifies things.

@timmywil timmywil merged commit 6546eeb into jquery:main Jul 11, 2023
@timmywil timmywil deleted the use-js branch July 11, 2023 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants