jQuery Dev Summit - Issue 44 #10
Conversation
There was a problem hiding this comment.
What's with these changes (and those below)?
There was a problem hiding this comment.
The "retrieve-git-authors" is async with a callback (it has to be due to using grunt's spawn function), so I moved some fo the code into the callback. It looks odd on the diff, but no code was actually moved just moved into the callback handler for the helper.
|
I don't think it will be used outside of this code. I changed it to be a function within the build.js file. |
|
@ajpiano will you test this? |
|
Dev summit issue 44 is now at jquery/learn.jquery.com#174 |
|
This belongs in learn.jquery.com's grunt file. This functionality isn't used anywhere else. |
|
@ronchalant any chance you can adapt this into a PR on learn.jquery.com? Would be greatly appreciated |
|
Sorry I've been laid up and now playing catchup at work - I can try to get to this in the next week or so. Not sure how pressing it is, let me know. |
First part of a fix for jquery/2012-dev-summit#44
Adds a helper that pulls git contributors for given files and returns them to a callback in an array such as:
[{"name":"adam j. sontag ","email":"ajpiano@ajpiano.com"},{"name":"Ralph Whitbeck ","email":"ralph.whitbeck@gmail.com"}]
The above is pushed to the post JSON object as "post.authors = [...]"
Did not utilize any piped commands, all deduping was done in Javascript to ensure the most cross-platform compatibility.
What remains is to determine how these authors would be included in the content markup, if at all.