Jquery Summit 2012 - closes #11 - Null signatures get class "null-signature" #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kswedberg can you test this? |
|
@jzaefferer tested locally and verbiage is approved now by karl |
|
My local setup is kinda messed up. I'd like to properly test this before merging. Only thing I could verify so far: The patch uses spaces instead of tabs. I'd appreciate if the submitter could fix that and rebase against upstream. If not, also fine, easy enough to fix with a cherry-pick. |
…aceholder where appropriate
|
I corrected the spaces/tabs issue and rebased on upstream/master. |
|
Thanks, landed in d60634f. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gives null-signature methods a single item that says "This method does not accept any arguments"