Skip to content

New task to verify local node_modules are installed and up-to-date. #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

jzaefferer
Copy link
Member

By adding this task to the build task to every project using grunt-jquery-content we get automatic verification that all necessary packages are installed and up-to-date.

This requires a recent version of npm to work. The one bundled with 0.8.4 is too old, 0.8.14 works.

I wonder if this could live in grunt-wordpress. It doesn't depend on anything jQuery-specific and would be nice to have in everything that uses grunt-wordpress, without having to add it explicitly.

@scottgonzalez
Copy link
Member

This definitely doesn't belong in grunt-wordpress. If you don't want it in grunt-jquery-content, then it should go in its own module (which should then become a dependency of grunt-jquery-content just so we don't have to include it separately in all projects).

if ( err ) {
grunt.verbose.error();
grunt.log.error( err );
done();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done( false );

@jzaefferer
Copy link
Member Author

Looking at this, I agree it should be a standalone plugin: http://bassistance.de/i/2bf10a.png
It'll be useful for jquery-ui as well. I'll work on that.

@jzaefferer jzaefferer closed this Oct 30, 2012
@jzaefferer
Copy link
Member Author

If you don't want it in grunt-jquery-content, then it should go in its own module (which should then become a dependency of grunt-jquery-content just so we don't have to include it separately in all projects).

I guess grunt-jquery-content will then use grunt.loadNpmTask to export it for whatever is using grunt-jquery-content?

@scottgonzalez
Copy link
Member

Seems reasonable.

@gnarf
Copy link
Member

gnarf commented Oct 31, 2012

Yes - jquery/grunt-npm-check ?

@jzaefferer
Copy link
Member Author

Latest status: jquery/jqueryui.com#23

@scottgonzalez scottgonzalez deleted the verify-packages branch December 5, 2014 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants