Skip to content

Add a note about the ui object passed to events when it contains no properties #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

tjvantoll
Copy link
Member

Let me know if there's a better way to implement the xsl here. I'm guessing there is. This does work though.

@@ -957,6 +957,11 @@
</xsl:call-template>
</div>
<xsl:call-template name="arguments"/>
<xsl:if test="argument[@name='ui']">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is a widget event, we can just assume that there is always a ui argument. Mobile uses the same name for their data object.

@scottgonzalez
Copy link
Member

I think we can just drop the first condition and land this.

@tjvantoll
Copy link
Member Author

I dropped the condition a08c9eb. If we ever have an event without a ui argument this message will be spit out, but if that day comes we can add the guard back in.

I can't rebase / land this because I don't have rights for this repo.

@scottgonzalez
Copy link
Member

Landed in 151d7ce.

If we ever have an event without a ui argument this message will be spit out, but if that day comes we can add the guard back in.

If that ever happens, the consistency is lost and the note becomes meaningless everywhere :-P

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants