Skip to content

Change no-arg signature text to "This signature" when multiple sigs #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

kswedberg
Copy link
Member

If a method has more than one signature, then the signature with no arguments should say "This signature does not accept any arguments" rather than "This method…"

@scottgonzalez
Copy link
Member

There are methods are aren't top-level entries, e.g., every method for widgets, so checking for //entry/signature isn't enough. Perhaps walk up to the <signature> and check for siblings?

@kswedberg
Copy link
Member Author

Yeah, that makes sense. Is the signature always the parent node of the argument (or non-argument, as the case may be)? If so, I can just do ../signature

@scottgonzalez
Copy link
Member

If there is a <signature>, it will be the parent, but there are other possible parents for <argument>. So I think your proposed check will work. If ../signature finds more than 1 element, use "signature" otherwise use "method". Just make sure it's an if/else, not two ifs like the first implementation.

@kswedberg
Copy link
Member Author

ok, I committed the changes. thanks for the feedback, @scottgonzalez. Since xslt has no if/else, i used choose>when/otherwise.

@scottgonzalez
Copy link
Member

Thanks. Landed in 2641e47 and released with v0.10.5. I also updated api.jquery.com and deployed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants