Strip the dynamically generated ID from syntaxhighligher, respect data-linenum #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t before it is placed into rendered HTML. Respect the "data-linenum" attr and pass it to node-syntaxhighlighter. Partially resolves jquery#5
…age information to prevent presentational styles from getting interpreted as language choies.
| @@ -110,10 +124,13 @@ grunt.registerHelper("syntax-highlight", function( options, callback ) { | |||
| highlight.each( function( index, el ) { | |||
| var $t = $(this), | |||
| code = $t.html(), | |||
| lang = $t.attr("data-lang") || $t.attr("class") || crudeHTMLcheck( code ), | |||
| lang = $t.attr("data-lang") || getLanguageFromClass( $t.attr("class") ) || crudeHTMLcheck( code ), | |||
| linenum = $t.attr("data-linenum") || 1, | |||
There was a problem hiding this comment.
If data-linenum is not specified, line numbers shouldn't be generated. If its present, but has no value, default to 1. If present, and has a value, use that.
|
Landed, cleaned up a little and release 0.3.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses 2 of the 3 points raised in #5. The last issue (syntax highlighting inside of
scriptin html pages) is blocked by thlorenz/node-syntaxhighlighter#2 for now.