Skip to content

Build: Upgrade grunt-check-modules, add .npmrc with save-exact=true #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

mgol
Copy link
Member

@mgol mgol commented Jun 1, 2016

Commit 1:

Build: Upgrade grunt-check-modules

This upgrade is necessary for grunt@1 compatibility

Commit 2:

Build: Add .npmrc with save-exact=true

This setting causes the npm install pkg@version --save command to always
save a pinned version to package.json instead of using the caret (^).

mgol added 2 commits June 1, 2016 12:09
This upgrade is necessary for grunt@1 compatibility
This setting causes the `npm install pkg@version --save` command to always
save a pinned version to package.json instead of using the caret (^).
@mgol
Copy link
Member Author

mgol commented Jun 22, 2016

Whou could review this? cc @jquery/content

@agcolom
Copy link
Member

agcolom commented Jun 22, 2016

My local setup is currently broken :-(
@kswedberg @AurelioDeRosa are you able to test this? Thanks!

@mgol
Copy link
Member Author

mgol commented Nov 16, 2016

Ping? It's been waiting for feedback for half a year now. :)

@kswedberg
Copy link
Member

Sorry, @mgol. I can look into this, but…

It looks like I don't have write access to this repo. :(

@agcolom
Copy link
Member

agcolom commented Nov 16, 2016

@mgol @kswedberg I don't seem to have write access either, so I can't grant you access.

@agcolom
Copy link
Member

agcolom commented Nov 16, 2016

@kborchers Would it be possible to give write access to this repo? Thanks!

@kswedberg
Copy link
Member

@mgol I opened my local copy api.jquery.com, went into the package.json of grunt-jquery-content, and copied the change you made in this PR (didn't add the .npmrc, but can't imagine that would hurt anything). Ran grunt deploy and everything worked.

So, LGTM 👍

If you have write access, feel free to merge it.

@kswedberg
Copy link
Member

p.s. I of course removed grunt-check-modules and then re-ran npm install too.

@mgol
Copy link
Member Author

mgol commented Nov 16, 2016

The whole content team should have access to this repo IMO. I don't seem to have access either.

@scottgonzalez
Copy link
Member

The content team now has write access.

@kswedberg kswedberg closed this in 29fa4be Nov 16, 2016
@mgol mgol deleted the grunt-1 branch November 23, 2016 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants