Skip to content

API sites: Make anchors for object properties and method arguments #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 13, 2018

Conversation

gibson042
Copy link
Member

No description provided.

@gibson042
Copy link
Member Author

I just noticed that this was still open. Any plans to land it?

@mgol
Copy link
Member

mgol commented Feb 11, 2018

@gibson042 if no one else objects I can land it. I'm not that familiar with XSLT, though so I'll just ask: are you convinced it works properly? Have you tested it locally?

@gibson042
Copy link
Member Author

Yes, I tested it with api.jquery.com. And I just remembered that it doesn't add links targeting the new property/argument ids (e.g., around the <strong> elements that serve as headings), in order to avoid affecting any styles (e.g., adding underlines to those headings). So as a result, the new ids are visible only in Dev Tools. I figure that can change later if so desired.

@gibson042
Copy link
Member Author

@mgol I just noticed the absence of these anchors again, and was just about to propose these changes again, until remembering that I already had. How about merging now?

@mgol mgol merged commit 4534d3e into jquery:master Jul 13, 2018
@mgol
Copy link
Member

mgol commented Jul 13, 2018

Landed. Thanks for the reminder.

@mgol
Copy link
Member

mgol commented Jul 13, 2018

I don't have publish rights to this package on npm. @dmethvin could you publish it? I assume npm version patch followed by npm publish should be fine. Or you can add me to the maintainers list, whichever you prefer.

@jzaefferer
Copy link
Member

jzaefferer commented Jul 13, 2018

Or you can add me to the maintainers list, whichever you prefer.

Only if you have 2FA enabled 💩 :shipit:

Since I'm also an owner - what's your npm username?

@mgol
Copy link
Member

mgol commented Jul 13, 2018 via email

@jzaefferer
Copy link
Member

Looks like this is you: https://www.npmjs.com/~mgol - adding now

@jzaefferer
Copy link
Member

Done

@mgol
Copy link
Member

mgol commented Jul 13, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants