-
Notifications
You must be signed in to change notification settings - Fork 32
API sites: Make anchors for object properties and method arguments #74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I just noticed that this was still open. Any plans to land it? |
@gibson042 if no one else objects I can land it. I'm not that familiar with XSLT, though so I'll just ask: are you convinced it works properly? Have you tested it locally? |
Yes, I tested it with api.jquery.com. And I just remembered that it doesn't add links targeting the new property/argument ids (e.g., around the <strong> elements that serve as headings), in order to avoid affecting any styles (e.g., adding underlines to those headings). So as a result, the new ids are visible only in Dev Tools. I figure that can change later if so desired. |
@mgol I just noticed the absence of these anchors again, and was just about to propose these changes again, until remembering that I already had. How about merging now? |
Landed. Thanks for the reminder. |
I don't have publish rights to this package on npm. @dmethvin could you publish it? I assume |
Only if you have 2FA enabled 💩 Since I'm also an owner - what's your npm username? |
I do! (since today morning...)
--
Michał Gołębiowski-Owczarek
|
Looks like this is you: https://www.npmjs.com/~mgol - adding now |
Done |
Thank you!
--
Michał Gołębiowski-Owczarek
|
No description provided.