Skip to content

API sites: Support multiple return types in function parameters #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 19, 2021

Conversation

anderlaw
Copy link
Contributor

@anderlaw anderlaw commented May 14, 2021

Cause I signed the wrong CLA data, So I update my commits and make a new PR against this one

Fixes jquery/api.jquery.com#1184

@mgol
Copy link
Member

mgol commented May 15, 2021

Thanks! For the sake of the future, you don't need to create a new PR in case of such issues. It's better to do changes on the same branch and push, potentially with the --force (or, better, --force-with-lease) flag and the PR will get updated automatically. This ways is better as then you have all the discussion history.

This should still be possible, I think, let me try closing this PR & re-opening the original one.

@mgol mgol closed this May 15, 2021
@mgol
Copy link
Member

mgol commented May 15, 2021

OK, it's not possible anymore since you removed or force-pushed the branch after closing the PR. Let's remember about that in the future, though.

@mgol mgol reopened this May 15, 2021
@mgol mgol mentioned this pull request May 15, 2021
@mgol
Copy link
Member

mgol commented May 15, 2021

Also, it's best to leave the main branch as following the upstream repository and not do any modifications to it but to instead create a separate branch for a PR. We have some guidelines on our Contribute page: https://contribute.jquery.org/commits-and-pull-requests/

@anderlaw
Copy link
Contributor Author

😁, I gotta admit that I did not read the guidelines well, I will definitely do that next time. Thanks for the suggestions

Copy link
Member

@mgol mgol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've just tested it; works great, thanks!

@mgol mgol changed the title support multiple return types API sites: Support multiple return types in function parameters May 19, 2021
@mgol mgol merged commit 8bd0226 into jquery:main May 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

.addClass section shows unexpected error message
2 participants