Skip to content

Do housekeeping + drop support for IE<9 #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Oct 25, 2016
Merged

Conversation

mgol
Copy link
Member

@mgol mgol commented May 25, 2016

Reviewing individual commits might be easier than the whole.

Fixes #89

@mgol
Copy link
Member Author

mgol commented May 25, 2016

@leobalter What can I do about the BrowserStack auth error?

@gnarf
Copy link
Member

gnarf commented May 25, 2016

Seems pretty good if we can fix the CI fail.

@gnarf
Copy link
Member

gnarf commented May 25, 2016

Not that it matters a ton, but I would think that instead of Core: this should be Color: on 835abb6 ?

@mgol
Copy link
Member Author

mgol commented May 25, 2016

Not that it matters a ton, but I would think that instead of Core: this should be Color: on 835abb6 ?

I used the component that's in the commitplease list. We'd need to change the list if you prefer different names.

@mgol
Copy link
Member Author

mgol commented May 25, 2016

I removed the outdated Core patch releases from available versions but I may add them back if you think it's worth it (I know UI tries to include everything).

@leobalter
Copy link
Member

It looks good, I just have not idea what is happening with browserstack now.

@leobalter
Copy link
Member

@mgol would you mind to rebase this branch? I believe this should be good now.

@leobalter
Copy link
Member

yes, as I imagine, it works perfectly. +1 to merge when it's rebased.

mgol added 9 commits October 25, 2016 00:31
This also changes the version string to be semver-valid.
This makes commands like `npm install package --save-dev` always get saved
to package.json as a pinned version and not as a `^`-delimited range.

Refs jquery/jquery#6600e2e2b9863dc91601d94541a3808cf3ccc90c
This also fixes a JSHint breakage that would occur on a fresh project
after running `npm install && grunt`.
…d ones

Also set jQuery 3.1.1 as the default tested version.
It was only needed for IE 6.
@mgol
Copy link
Member Author

mgol commented Oct 24, 2016

Rebased. I also modified some middle commits (e.g. the one including jQuery 3.0.0-rc1 now includes 3.0.0 final & 3.1.1 instead).

IMO it all makes sense to land as separate commits. WDYT?

@leobalter leobalter merged commit 2822192 into jquery:master Oct 25, 2016
@leobalter
Copy link
Member

GitHub swallowed to the void the comment I sent from email.

Yes I agree it makes sense to land with separate commits.

@leobalter
Copy link
Member

I agree, that's why I asked you to rebate, so I can merge through GitHub
keeping track of the PR for all of them.

I'll merge as soon I get into a computer (currently on my phone)

On Monday, October 24, 2016, Michał Gołębiowski notifications@github.com
wrote:

Rebased. I also modified some middle commits (e.g. the one including
jQuery 3.0.0-rc1 now includes 3.0.0 final & 3.1.1 instead).

IMO it all makes sense to land as separate commits. WDYT?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#104 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AASYkf3dzP5e5l45in61OOVzC5kpfL-qks5q3TWNgaJpZM4ImecC
.

@mgol mgol deleted the major branch October 26, 2016 09:55
@mgol mgol added this to the 3.0.0 milestone May 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Drop IE 6 "fake alpha" support?
4 participants