Core: Fix parsing to preserve CSS variables with fallback colors - #180
Open
Krinkle wants to merge 1 commit into
Open
Core: Fix parsing to preserve CSS variables with fallback colors#180Krinkle wants to merge 1 commit into
Krinkle wants to merge 1 commit into
Conversation
Krinkle
force-pushed
the
fix-css-var
branch
3 times, most recently
from
July 22, 2026 18:27
66e5fc1 to
acc45ae
Compare
Before:
```
$('<div>').css('color', 'var(--color-base, #202122)').attr('style');
//> color: rgb(32, 33, 34);
```
After:
```
$('<div>').css('color', 'var(--color-base, #202122)').attr('style');
//> var(--color-base, #202122)
```
The "with fallback" test cases fail without the patch:
> message: Declared value
> expected: "rgba(255, 255, 0, 0)"
> actual: "var(--example-not-found,#ff0077)"
To minimise the impact of this change, make whitespace tolerance
explicit in the regex. This was previousluy implict because the
regex wasn't anchored. Whitespace tolerance isn't just theoretical
back-compat, it matches native DOM behaviour and (without this plugin)
jQuery Core behavior:
```
var d = document.createElement('div');
d.style.color = ' #202FF2 ';
d.style.color;
//> "rgb(32, 47, 242)"
```
Fixes jquery/jquery-ui#2411.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before:
After:
The "with fallback" test cases fail without the patch:
To minimise the impact of this change, make whitespace tolerance explicit in the regex. This was previousluy implict because the regex wasn't anchored. Whitespace tolerance isn't just theoretical back-compat, it matches native DOM behaviour and (without this plugin) jQuery Core behavior:
Fixes jquery/jquery-ui#2411.