Skip to content

Remove the code from jQuery versions older than 1.12/2.2 #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mgol opened this issue Feb 25, 2016 · 2 comments
Closed

Remove the code from jQuery versions older than 1.12/2.2 #152

mgol opened this issue Feb 25, 2016 · 2 comments
Assignees
@mgol
Milestone
3.0.0

Comments

@mgol
Copy link
Member

mgol commented Feb 25, 2016

Since Migrate 3.0 is supposed to work only with jQuery 1.12/2.2, it shouldn't restore behavior not present in these versions, e.g. jQuery.browser, jQuery.support.boxModel, jQuery.sub & others.
@mgol mgol added this to the 3.0.0 milestone Feb 25, 2016
@mgol mgol self-assigned this Feb 25, 2016
@dmethvin
Copy link
Member

Yes, agreed that a lot of the older functionality should be removed. Nobody using jQuery 3.0 should also be using jQuery.browser! Basically #120 is about updating the README to explain how someone would get, say, from 1.9.1 to 3.0.0.

I think we agreed it would be a two-step process where someone would run with Migrate 1.4.0 (or later), fix problems, then use Migrate 3.0.0.

I think we specifically wanted to avoid having people "stack" Migrates to get things working. 😸

mgol added a commit to mgol/jquery-migrate that referenced this issue Feb 25, 2016
@mgol
Core: Warn against using jQuery.parseJSON, remove old hacks around th…
2c5fb7c 
…is method

Fixes jquery#150
Refs jquery/jquery#2800
Refs jquery#152
@mgol mgol mentioned this issue Feb 25, 2016
Merged
mgol added a commit to mgol/jquery-migrate that referenced this issue Feb 25, 2016
@mgol
Core: Warn against using jQuery.parseJSON, remove old hacks around th…
befbed9 
…is method

Fixes jquery#150
Refs jquery/jquery#2800
Refs jquery#152
mgol added a commit to mgol/jquery-migrate that referenced this issue Mar 2, 2016
@mgol
Core: Warn against using jQuery.parseJSON, remove old hacks around it
5de065f 
Fixes jquery#150
Refs jquery/jquery#2800
Refs jquery#152
Closes jquery#153
mgol added a commit to mgol/jquery-migrate that referenced this issue Mar 2, 2016
@mgol
Core: Warn against using jQuery.parseJSON, remove old hacks around it
39fa123 
Fixes jquery#150
Refs jquery/jquery#2800
Refs jquery#152
Closes jquery#153
mgol added a commit to mgol/jquery-migrate that referenced this issue Mar 3, 2016
@mgol
Core: Remove workarounds for APIs dropped before 3.0
0c34636 
Fixes jquery#152
@mgol mgol mentioned this issue Mar 3, 2016
Closed
@mgol
Copy link
Member Author

mgol commented Mar 3, 2016

PR: #155. Review appreciated.

mgol added a commit to mgol/jquery-migrate that referenced this issue Mar 3, 2016
@mgol
Core: Remove workarounds for APIs dropped before 3.0
472f790 
Fixes jquery#152
mgol added a commit to mgol/jquery-migrate that referenced this issue Mar 3, 2016
@mgol
Core: Remove workarounds for APIs dropped before 3.0
750d071 
Fixes jquery#152
@mgol mgol closed this as completed in f26c293 Mar 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mgol mgol

Labels
None yet
Projects
None yet
Milestone
3.0.0
Development

No branches or pull requests
2 participants
@dmethvin @mgol