Restore previous replaceWith behavior

[nicofrand]

In jQuery < 1.9, replaceWith removed the current node if the content was null, undefined or an empty jQuery object.
Ex:

<div id="foo"></div>
$("#foo").replaceWith(function()
{
    return $(this).contents();
});

Expected Result :
DIV#foo is removed (ok in jQuery 1.8.3)

Actual result:
DIV#foo still exists.

How to restore the previous behavior :

$("#foo").remove(":empty").replaceWith(function()
{
    return $(this).contents();
});

[dmethvin]

Can you provide a jsFiddle example? If I understand your snippet it sounds like $(this).contents() returns nothing which means it reduces to $("#foo").replaceWith([]) but an executable code sample would be less ambiguous.

[nicofrand]

Sorry, I did not notice the HTML I wrote was not displayed.
Indeed, the contents method returns an empty object. Here is the jsFiddle example : http://jsfiddle.net/T5CjG/3/, please try with jQuery 1.8.3 and jQuery 1.9.1.
I hope this will be clear enough this time.

[dmethvin]

Simpler and clearer test case: http://jsfiddle.net/dmethvin/T5CjG/4/

This seems more like a 1.9.1 bug and not something Migrate should handle. What do you think @gibson042 ?

[gibson042]

This feels more like a 1.9 bug than a jquery-migrate one. The emptiness test in .replaceWith is too narrow; we should always call .domManip and then follow it with .remove() in case of no-op.

[gibson042]

http://bugs.jquery.com/ticket/13596