-
Notifications
You must be signed in to change notification settings - Fork 475
Make sure the minified file is, in fact, minified #300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
It's minified but still has the original newlines, which we don't do in any of the other jQuery files. It's correct in the 3.0.0.min release, I'll take a look. |
Yeah, it looks like some minification flags were off. |
We moved from grunt-config-uglify 1.0.1 to 3.0.1. Fortunately it looks like @markelog just did this for core and it has a bunch of options in that Gruntfile so I can copy that. |
Fixes jquery#300 This PR also switches to the minified file as the default for testing.
@dmethvin - is there an extra step that needs to be done so that the 3.0.1.min.js can have the new settings applied to it? It still looks to have all the newlines. |
@georgezee We can't change the files of already released versions so this will be fixed only starting with the next version of Migrate. |
Ok sure - @mgol - thanks for clarifying. |
Originally reported at jquery/codeorigin.jquery.com#33 by @buismaarten:
The text was updated successfully, but these errors were encountered: