Skip to content

Make sure the minified file is, in fact, minified #300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mgol opened this issue Mar 28, 2018 · 6 comments
Closed

Make sure the minified file is, in fact, minified #300

mgol opened this issue Mar 28, 2018 · 6 comments
Assignees
Milestone

Comments

@mgol
Copy link
Member

mgol commented Mar 28, 2018

Originally reported at jquery/codeorigin.jquery.com#33 by @buismaarten:

Hey guys,

Look at this url: http://code.jquery.com/jquery-migrate-3.0.1.min.js
At the end it says ".min", but the file isn't minified.

@dmethvin
Copy link
Member

It's minified but still has the original newlines, which we don't do in any of the other jQuery files. It's correct in the 3.0.0.min release, I'll take a look.

@dmethvin dmethvin self-assigned this Mar 28, 2018
@mgol
Copy link
Member Author

mgol commented Mar 28, 2018

Yeah, it looks like some minification flags were off.

@dmethvin
Copy link
Member

We moved from grunt-config-uglify 1.0.1 to 3.0.1. Fortunately it looks like @markelog just did this for core and it has a bunch of options in that Gruntfile so I can copy that.

dmethvin added a commit to dmethvin/jquery-migrate that referenced this issue Mar 31, 2018
Fixes jquery#300

This PR also switches to the minified file as the default for testing.
dmethvin added a commit to dmethvin/jquery-migrate that referenced this issue Apr 12, 2018
@georgezee
Copy link

@dmethvin - is there an extra step that needs to be done so that the 3.0.1.min.js can have the new settings applied to it? It still looks to have all the newlines.
Or will this only take effect from 3.0.2 onwards?

@mgol
Copy link
Member Author

mgol commented Jun 25, 2018

@georgezee We can't change the files of already released versions so this will be fixed only starting with the next version of Migrate.

@georgezee
Copy link

Ok sure - @mgol - thanks for clarifying.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants