Skip to content

Fill in & warn against using push, sort & splice on jQuery objects #473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mgol opened this issue Aug 18, 2022 · 3 comments · Fixed by #529
Closed

Fill in & warn against using push, sort & splice on jQuery objects #473

mgol opened this issue Aug 18, 2022 · 3 comments · Fixed by #529
Assignees
Milestone

Comments

@mgol
Copy link
Member

mgol commented Aug 18, 2022

Those methods were removed in jquery/jquery#4473. They were not public API but I expect there may be a lot of usage in the wild, e.g. AngularJS uses those methods on jQuery objects.

We should fill them in & warn against the usage.

@BackuPs
Copy link

BackuPs commented Aug 27, 2024

I just tested jquery 4.0 and instantly ran into 5 plugins that stopped working because of this.

Imho these undocumented Api's are more widely used then i think the jQuery Developers realise. Removing api's functionality because they are not documented without informing and warning does not seem to be a good idea.

I am totally support the idea, although "it is not documented", to create a deprecation path in order to avoid websites stop working.

Thank you.

@mgol
Copy link
Member Author

mgol commented Aug 27, 2024

These APIs will be backfilled by jQuery Migrate prior to the jQuery 4.0.0 final release, so you'll be able to continue using them for as long as you need to get rid of them all. We'll also keep jQuery 3.x secure for some time after the 4.0.0 final release, possibly even for a few years.

@mgol
Copy link
Member Author

mgol commented Sep 16, 2024

PR: #529

mgol added a commit to mgol/jquery-migrate that referenced this issue Sep 16, 2024
mgol added a commit to mgol/jquery-migrate that referenced this issue Sep 16, 2024
@mgol mgol closed this as completed in #529 Sep 16, 2024
@mgol mgol closed this as completed in 95d05ce Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants