Skip to content

jQuery.migrateWarningsTrace property to enable console traces #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

jQuery.migrateWarningsTrace property to enable console traces #10

wants to merge 1 commit into from

Conversation

silentroach
Copy link
Contributor

It is very hard to find deprecated jQuery calls only by warnings.

console.trace() is great to find what was called and where.

@mikesherov
Copy link
Member

👍

@JorisDebonnet
Copy link

I agree. I had to go into the Migrate code to insert some additional tracing code in order to find what was causing my warning (in issue #11). It would be handy if this was just standard behavior in jQuery Migrate.

@dmethvin
Copy link
Member

Rather than adding another property, perhaps jQuery.migrateWarn="trace" would do it. It would need to fall back for browsers that don't support trace.

@dmethvin
Copy link
Member

oh nevermind, I was thinking of the old code that has migrateWarn.

@silentroach
Copy link
Contributor Author

Seems like it is ok with patch. Will you merge? :)

@dmethvin
Copy link
Member

Yes, I will make a couple of small changes and land this. @silentroach can you sign our CLA at http://jquery.github.com/cla.html ? Thanks.

@silentroach
Copy link
Contributor Author

Thank you.
CLA is signed.

@dmethvin dmethvin closed this in 1a89479 Jan 17, 2013
@dmethvin
Copy link
Member

@silentroach Thanks so much for pointing this out! I had totally forgotten about console.trace(). Since people who really need this tend to have trouble following even the simplest instructions I made it the default but it can be disabled by setting the property to false. The minified plugin still keeps quiet about warnings.

dmethvin added a commit that referenced this pull request Jan 19, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants