Skip to content

fix(README): point to v1.4.0 release urls #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

thgreasi
Copy link
Contributor

No description provided.

@mention-bot
Copy link

By analyzing the blame information on this pull request, we identified @coliff, @scottgonzalez and @markelog to be potential reviewers

@jquerybot
Copy link

Thank you for your pull request. It looks like this may be your first contribution to a jQuery Foundation project, if so we need you to sign our Contributor License Agreement (CLA).

📝 Please visit http://contribute.jquery.org/CLA/ to sign.

After you signed, the PR is checked again automatically after a minute. If there's still an issue, please reply here to let us know.


If you've already signed our CLA, it's possible your git author information doesn't match your CLA signature (both your name and email have to match), for more information, check the status of your CLA check.

@coveralls
Copy link

coveralls commented Apr 22, 2016

Coverage Status

Coverage remained the same at 89.655% when pulling 0f1fe01 on thgreasi:patch-1 into 89e461e on jquery:master.

@dmethvin
Copy link
Member

This isn't the latest README on master. Take a look at that one. Is the information you need there?

@thgreasi
Copy link
Contributor Author

thgreasi commented Apr 22, 2016

I'm a bit puzzled by your answer.
I think that I'm targeting the README of the jquery:master branch which only includes references to v1.3.0.
Do you mean the file in the 1.x-stable branch (which I just realized that existed)?

So, I guess you can close this, if the master branch is only used for jquery v3.0 development...
On the other hand, others might get confused (like I did) when landing on the main page of the repo.

@dmethvin
Copy link
Member

Oh okay I see what you mean. Those will be updated to the 3.0 branch as soon as the first 3.0 release is made, the build script does it. If you're looking for 1.x code then the link up top should point to the README for that branch, and it has accurate information for the 1.x branch since a release has already been run against it. I can land this for now though, but people looking for the 1.x code should not be reading further into the README here because it doesn't apply to the 1.x branch.

@dmethvin
Copy link
Member

Landed at ee0a030

Thanks! Had you noticed the big link to 1.x before? I think this might become more of an issue when the first 3.0 release ships if a lot of people are looking for 1.x and get 3.x by accident, but I tried to make the link at the top as large as possible.

@dmethvin dmethvin closed this Apr 22, 2016
@thgreasi
Copy link
Contributor Author

Interestingly enough I did notice the v3.0 header but it looks like my
brain just skipped that and searched for a cdn url. 👍

Thodoris Greasidis
Computer, Networking &
Communications Engineer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants