Build: Add code for strict mode #180
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Duh fixes #179 |
|
Interesting, no changes required to pass the tests? :) LGTM then! |
| @@ -1,3 +1,2 @@ | |||
| (function( jQuery, window, undefined ) { | |||
There was a problem hiding this comment.
BTW, we could drop the undefined; Core doesn't protect itself from undefined shadowing anymore so there's no reason Migrate should.
|
I tried it on all the desktop browsers and Android 4.1, they seemed to be fine. I even tried it on IE8 not really thinking. It doesn't work there. 😛 We'll see if the whole suite has any issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if I should have any other tests here. I don't need or need to put all the tests into strict mode.