Skip to content

Add support for integrating with external reporting #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

Add support for integrating with external reporting #196

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c89540f
Simplify integration with reporting tools
sullivanst May 27, 2016
8698dd6
Make it lint
sullivanst May 27, 2016
6f78e58
Fix spacing for lint style
sullivanst May 27, 2016
02c4f38
Add check for warning as Errors
sullivanst May 27, 2016
b72995e
Tests: get passing
mattwTS May 27, 2016
97eddc0
Add missing Error wrapper
sullivanst May 28, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add check for warning as Errors
  • Loading branch information
@sullivanst
sullivanst committed May 27, 2016
commit 02c4f38626fde9a0e1fd6dc6ae0d9a811f7bda2c
1 change: 1 addition & 0 deletions test/migrate.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ function expectWarning( name, expected, fn ) {
// Simple numeric equality assertion for warnings matching an explicit count
} else if ( expected && jQuery.migrateWarnings.length === expected ) {
equal( jQuery.migrateWarnings.length, expected, name + ": warned" );
equal( jQuery.migrateWarnings.asErrors.length, expected, name + ": warned as Errors" );

// Simple ok assertion when we saw at least one warning and weren't looking for an explict count
} else if ( !expected && jQuery.migrateWarnings.length ) {
Expand Down