Skip to content

Effects: Warn and fill jQuery.fx.interval #216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

dmethvin
Copy link
Member

@dmethvin dmethvin commented Aug 3, 2016

Fixes #215

@mention-bot
Copy link

@dmethvin, thanks for your PR! By analyzing the annotation information on this pull request, we identified @markelog, @mgol and @silentroach to be potential reviewers

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.05%) to 87.5% when pulling a2df588 on dmethvin:dp-fxinterval into 6041d46 on jquery:master.

@mgol
Copy link
Member

mgol commented Aug 3, 2016

LGTM.

@mgol
Copy link
Member

mgol commented Aug 3, 2016

Or maybe we could add a test ensuring no warnings happen for browsers not having rAF?

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.05%) to 87.5% when pulling 8551ddc on dmethvin:dp-fxinterval into 6041d46 on jquery:master.

@dmethvin
Copy link
Member Author

dmethvin commented Aug 5, 2016

I refactored the tests a bit to assert that non-rAF browsers don't warn. Coverage decreases since the tests are conditioned on the presence of rAF. I checked manually on IE9 and Android and it reports correctly.

@dmethvin dmethvin closed this in a46e4b9 Aug 5, 2016
@dmethvin dmethvin deleted the dp-fxinterval branch September 26, 2016 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants