Core: Don't use .apply() on console.log to satisfy IE9 #241
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dmethvin, thanks for your PR! By analyzing the history of the files in this pull request, we identified @mgol, @silentroach and @markelog to be potential reviewers. |
|
LGTM. I don't see a way to test it in IE 9 but we could simulate its situation via: if ( !window.console ) {
window.console = {};
}
if ( !window.console.log ) {
window.console.log = function () {};
window.console.log.__proto__ = null;
} |
markelog
reviewed
Nov 28, 2016
|
|
||
| if ( !log ) { | ||
| // IE9 console is a host object, callable but doesn't have .apply() | ||
| if ( !window.console || !window.console.log ) { |
There was a problem hiding this comment.
typeof window.console.apply wouldn't work?
There was a problem hiding this comment.
It won't as there is no window.console in IE 9.
There was a problem hiding this comment.
Right, and even when window.console exists in IE9 (when the debugger window is active) it is a "host object" that is callable but doesn't have .apply().
mgol
approved these changes
Jan 23, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #231
Not sure of a good way to test this for IE9, which is why the problem existed in the first place.