Skip to content

Build: Improve ESLint configuration, check all test files as well #339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 19, 2020

Conversation

mgol
Copy link
Member

@mgol mgol commented Apr 14, 2020

The new ESLint setup is largely based on the current jQuery Core one.

@mgol mgol requested a review from dmethvin April 14, 2020 15:57
The new ESLint setup is largely based on the current jQuery Core one.
Copy link
Member

@dmethvin dmethvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At some point I'd love to use some other formatting that could be enforced by Prettier for example. I'm so spoiled by my other work where I don't even think about formatting anything.

@mgol mgol merged commit c6cfba2 into jquery:master Apr 19, 2020
@mgol mgol deleted the eslint branch April 19, 2020 19:02
@mgol
Copy link
Member Author

mgol commented Apr 19, 2020

@dmethvin Oh, I use Prettier at work and I can confirm not having to care about code formatting, just typing & pressing save to auto-format is a wonder. For jQuery, however, we've been using the existing code style for so long adding Prettier now would reformat almost every single line (Prettier code style is far different from the jQuery one) which would make blames harder. Also, one drawback of Prettier is various aspects of their imposed code style change from time to time so we'd have to reformat periodically.

Code in Migrate comes & goes so it's not that important here but being consistent with jQuery Core seems valuable to me. In the end, it's your choice, though. :)

@mgol mgol added this to the 3.3.0 milestone May 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants