Offset: Fix the offset patch #352
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes:
* `.offset()` works on `document.documentElement`
* `.offset()` setter on an empty object returns the source object, not undefined
* `.offset()` setter on a disconnected node returns the source object, not
`{ top: 0, left: 0}`
mgol
added a commit
to mgol/jquery-migrate
that referenced
this pull request
May 16, 2020
`.offset()` in jQuery 3.0.0-3.1.1 sometimes returns an object with more than just `top` & `left` properties. This was fixed in jQuery 3.2.0. Since we're not in a business of fixing older jQuery versions here, this commit updates the test instead. Ref jquery/jquery#3367 Ref jquerygh-352
mgol
added a commit
that referenced
this pull request
May 16, 2020
`.offset()` in jQuery 3.0.0-3.1.1 sometimes returns an object with more than just `top` & `left` properties. This was fixed in jQuery 3.2.0. Since we're not in a business of fixing older jQuery versions here, this commit updates the test instead. Ref jquery/jquery#3367 Ref gh-352 Closes gh-355
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
.offset()works ondocument.documentElement.offset()setter on an empty object returns the source object, not undefined.offset()setter on a disconnected node returns the source object, not{ top: 0, left: 0 }