Skip to content

CSS: Don't break .css( array ) #356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 20, 2020
Merged

CSS: Don't break .css( array ) #356

merged 1 commit into from
May 20, 2020

Conversation

mgol
Copy link
Member

@mgol mgol commented May 18, 2020

jQuery 3.3.0 1.9 added support for array input to the .css() method; so far
Migrate was crashing with such input.

Fixes gh-357

@mgol mgol added this to the 3.3.1 milestone May 18, 2020
@mgol mgol requested a review from dmethvin May 18, 2020 15:42
@mgol mgol self-assigned this May 18, 2020
jQuery 1.9 added support for array input to the `.css()` method; so far
Migrate was crashing with such input.

Fixes jquerygh-357
Copy link
Member

@dmethvin dmethvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

D'oh!

@mgol mgol merged commit 0933a39 into jquery:master May 20, 2020
@mgol mgol deleted the css-array branch May 20, 2020 07:16
mgol added a commit to mgol/jquery-migrate that referenced this pull request May 20, 2020
line-height used value is measured in pixels in IE & old Firefox, let's use
z-index instead.

Ref jquerygh-356
mgol added a commit that referenced this pull request Jun 6, 2020
line-height used value is measured in pixels in IE & old Firefox, let's use
z-index instead.

Ref gh-356
Closes gh-362
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exception when using css function with an array as argument
2 participants