Offset: Don't warn against usage on disconnected elements #359
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The initial decision to not support disconnected elements as input to the
`.offset()` getter was reversed after feedback from jQuery UI (see gh-2310).
Since jQuery now ensures disconnected element get `{ left: 0, top: 0 }` from
this method via unit tests it doesn't make sense to warn against such usage.
This change is the only remaining one in Migrate & UI that's required for UI
to trigger no Migrate warnings when running its test suite.
Ref gh-2310
Ref gh-2396
dmethvin
approved these changes
May 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The initial decision to not support disconnected elements as input to the
.offset()getter was reversed after feedback from jQuery UI (see jquery/jquery#2310).Since jQuery now ensures disconnected element get
{ left: 0, top: 0 }fromthis method via unit tests it doesn't make sense to warn against such usage.
This change is the only remaining one in Migrate & UI that's required for UI
to trigger no Migrate warnings when running its test suite.
Ref jquery/jquery#2310
Ref jquery/jquery#2396