Build: Allow to pass browserSets & jQuery version to testswarm task #59
Conversation
|
Well, it's complicated. The current test runs through this list of file combos to make sure Migrate's dev version (which has console output) and min version (which doesn't) work properly with jQuery core versions back to 1.6.4. Since some of those are 2.x versions they can't run on oldIE. What we really need are two separate jobs to handle the 1.x and 2.x core branches, with different browser sets. I had planned to do that but didn't get around to it! |
So far, Migrate has been tested only on browsers supported by jQuery 2.x. This commit changes the configuration so that different browserSets can be tested with jQuery 2.x and 1.x. Closes jquerygh-59
|
@dmethvin I updated the PR; now it auguments the testswarm task config instead. Once this is ready to merge, I'll need to clone the Migrate Jenkins job and adjust settings passed to the task. Then, older IE versions will be tested as well. (BTW, should I add IE6-8 to the older set or just IE8?) |
|
So is this one ready to land? |
|
Yes, I think so. I'll need to add a separate Jenkins job once it lands (just landing will actually decrease what's tested since only Core 2.x will be tested by default) so I'd like to do those things at the same time. Can I land it? |
So far, Migrate has been tested only on browsers supported by jQuery 2.x. This commit changes the configuration so that different browserSets can be tested with jQuery 2.x and 1.x. Closes jquerygh-59
|
go for it |
So far, Migrate has been tested only on browsers supported by jQuery 2.x. This commit changes the configuration so that different browserSets can be tested with jQuery 2.x and 1.x. Closes jquerygh-59
|
The first two jobs were generated:
Unfortunately, there is some problem with IE8, it's failing quickly, in testinit itself; see e.g: http://swarm.jquery.org/result/1901102. The message says: |
|
OK, no idea why it's reported this way. I run it on IE8 in BrowserStack and there are 3 errors; see screenshots: |
|
Well, the failure point gives a possible reason: 😸 https://github.com/jquery/jquery-migrate/blob/master/test/testinit.js#L66 I don't recall if QUnit every created an extension point to do what that needs done, which is to let us have select boxes in their toolbar. |
|
Seems like it should fail everywhere though, doesn't it? Maybe the testinit code is reached too early, but I dunno why that would be. |
Migrate should be tested against oldIE, hence the
popularbrowser set. Also, we've started testing against theiosbrowser set (currently iOS6 only), Migrate should be tested against it as well.@dmethvin Why was the
popular-no-old-iebrowser set set here?