Skip to content

Repo: Update bower.json along with package.json when updating versions #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

timmywil
Copy link
Member

Whenever a version number is changed, repo calls Release._setVersions( version ). No new public methods are added.

To add more json files to the verison update list, one could update the array at Release._jsonFiles.

Fixes gh-4

@timmywil
Copy link
Member Author

Much of the abstraction before has been removed.

@jzaefferer
Copy link
Member

Looks good to me. Would be useful for the next QUnit release as well.

@gseguin
Copy link
Member

gseguin commented Jan 3, 2014

👍

@jzaefferer
Copy link
Member

Just tested this together with my own PR (#23), works well. There's a tiny merge conflict when applying both this and #23, but its really easy to resolve (remove var package, keep the Release.chdir line).

@timmywil timmywil closed this in f85ecb1 Jan 3, 2014
@jzaefferer
Copy link
Member

Landed in master. Thanks @timmywil.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Publish to Bower
3 participants