Skip to content

NPM: Verify credential upfront #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

NPM: Verify credential upfront #36

wants to merge 1 commit into from

Conversation

scottgonzalez
Copy link
Member

Fixes gh-27

jzaefferer
jzaefferer reviewed Mar 14, 2014
View reviewed changes
lib/npm.js
},

_checkNpmCredentials: function() {
if ( !Release.npmPublish ) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will always be falsy, as long as _checkNpmCredentials is called before _cloneRepo, since only afterwards might Release.npmPublish be true.

@jzaefferer
Copy link
Member

Moved the _checkNpmCredentials and landed.

@jzaefferer
Copy link
Member

Afterwards found an issue, where the npm check uses Release.project, which doesn't match the npm package name for QUnit, where its qunitjs. Will fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Verify npm credentials upfront
2 participants
@scottgonzalez @jzaefferer