-
Notifications
You must be signed in to change notification settings - Fork 30
NPM: Add npmTags() to provide full control over which tags are used #48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Fixes gh-29 Fixes gh-30
|
Seems like we'd still end up with |
|
You'd never tag 1.x as latest. |
|
Okay, I was confused about npm's nomenclature for "tag", the version is handled separately. LGTM then. |
|
LGTM. |
|
I just did a test run with QUnit, without any modifications in the release script, and it would run these commands: npm publish --tag latest
npm tag qunitjs@1.14.1 betaStill need to verify that setting custom tags works properly as well. |
|
PR for Core: jquery/jquery#1553 |
|
Sorry, only now did I see the README entry: |
|
The release number itself is the tag yeah? |
It's a requirement of npm; you cannot publish without a tag. |
Yet another reason for us to create a |
There's already a PR for that: jquery/jquery#1553 |
Fixes gh-29
Fixes gh-30
I'd like to have @jquery/core verify that this addresses their needs for handling 1.x/2.x simultaneous releases by overriding
npmTags()on the 1.x-master branch.