Skip to content

Conversation

@scottgonzalez
Copy link
Member

Fixes gh-29
Fixes gh-30

I'd like to have @jquery/core verify that this addresses their needs for handling 1.x/2.x simultaneous releases by overriding npmTags() on the 1.x-master branch.

@dmethvin
Copy link
Member

Seems like we'd still end up with latest tagged wrong if we released 2.x and 1.x in that order?

@scottgonzalez
Copy link
Member Author

You'd never tag 1.x as latest.

@dmethvin
Copy link
Member

Okay, I was confused about npm's nomenclature for "tag", the version is handled separately. LGTM then.

@mgol
Copy link
Member

mgol commented Mar 31, 2014

LGTM.

@jzaefferer
Copy link
Member

I just did a test run with QUnit, without any modifications in the release script, and it would run these commands:

npm publish --tag latest
npm tag qunitjs@1.14.1 beta

Still need to verify that setting custom tags works properly as well.

@jzaefferer
Copy link
Member

PR for Core: jquery/jquery#1553

@mgol
Copy link
Member

mgol commented Apr 1, 2014

Sorry, only now did I see the README entry: Every release must contain at least one tag. Why is that? Currently we don't apply any tags to jQuery 1.x.

@gnarf
Copy link
Member

gnarf commented Apr 1, 2014

The release number itself is the tag yeah?

@scottgonzalez
Copy link
Member Author

Sorry, only now did I see the README entry: Every release must contain at least one tag. Why is that? Currently we don't apply any tags to jQuery 1.x.

It's a requirement of npm; you cannot publish without a tag.

@mgol
Copy link
Member

mgol commented Apr 1, 2014

Sorry, only now did I see the README entry: Every release must contain at least one tag. Why is that? Currently we don't apply any tags to jQuery 1.x.

It's a requirement of npm; you cannot publish without a tag.

Yet another reason for us to create a 1.x tag.

@scottgonzalez
Copy link
Member Author

Yet another reason for us to create a 1.x tag.

There's already a PR for that: jquery/jquery#1553

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

NPM: Always set the beta tag NPM: Full control over tags

5 participants