All: Replace Release.project with more appropriate values #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
| var result = Release.readPackage()[ field ]; | ||
|
|
||
| // Make sure it exists | ||
| if (!result) { |
|
Overall, this looks good. |
jzaefferer
added a commit
to jzaefferer/jquery-release
that referenced
this pull request
Mar 24, 2014
|
Since those two methods are currently used only in |
|
The methods only need to be documented if they're intended to be used in a project-specific script. |
jzaefferer
added a commit
to jzaefferer/jquery-release
that referenced
this pull request
Mar 24, 2014
Use package name for CDN. Use bugs and repository fields for changelog. Adds a _packageUrl method that the Trac module can also use. Fixes gh-49 Closes jquerygh-52
|
Okay, updated. |
|
Looks good. |
jzaefferer
added a commit
to jzaefferer/jquery-release
that referenced
this pull request
Mar 24, 2014
Use package name for CDN. Use bugs and repository fields for changelog. Adds a _packageUrl method that the Trac module can also use. Fixes gh-49 Closes jquerygh-52
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use package name for CDN. Use bugs and repository fields for changelog.
Adds a _packageUrl method that the Trac module can also use.
Fixes gh-49
Closes gh-52
#50 and #51 were side effects while working on this. I actually missed the change from #50 a few times, since I put that in a separate branch.
Tested this against fake-project, jquery, jquery-ui, jquery-mobile and qunit. Since the changelog generation is barely working, I specifically check the return value of
_ticketUrland_repositoryUrlfor each.