Changelog: Use changelogplease for git parsing #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| changelog = Release.changelogShell() + | ||
| Release._generateCommitChangelog() + | ||
| _generateChangelog: function( callback ) { | ||
| var changelogPath = Release.dir.base + "/changelog"; |
There was a problem hiding this comment.
Might as well move this variable into the below callback, since that's the only scope where its being used.
|
Looks good overall, just those two small issues. Will look at current state of |
When generating a new stack trace, don't include Release.abort().
|
I made both changes. The error logging is handled through |
|
Can you update |
|
Changes and resulting code look good. Trimming dependencies would be nice. |
scottgonzalez
added a commit
that referenced
this pull request
Mar 26, 2014
When generating a new stack trace, don't include Release.abort(). Ref gh-53
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes gh-7