CDN: Allow disabling via cdnPublish flag #56
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
| @@ -235,6 +235,10 @@ The previous release version (used for determining what changed). | |||
|
|
|||
| The version that will be set in `package.json` after the release. | |||
|
|
|||
| #### cdnPublish | |||
|
|
|||
| Set to `true` to publish a release to the jQuery CDN. Defaults to `true`. | |||
There was a problem hiding this comment.
This should be inverted: "Set to false to prevent publishing to the jQuery CDN. Defaults to true."
|
Other than the minor docs change, this looks good. |
jzaefferer
added a commit
to jzaefferer/jquery-release
that referenced
this pull request
Mar 31, 2014
Fixes gh-55 Closes jquerygh-56
Fixes gh-55 Closes jquerygh-56
|
Fixed the README and landed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes gh-55